Stop premature warnings, including nix.settings migration
#163451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for sinceRelease
Out-of-tree modules that use it can not upgrade yet. There's no real hurry and we should avoid warning fatigue.
This was referenced Mar 9, 2022
|
Please review :) /marvin opt-in |
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
kevincox
reviewed
Mar 21, 2022
Let's keep things simple and not poke holes in the improved migration process.
kevincox
approved these changes
Mar 21, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Some deprecations should not take effect immediately.
This adds
libcode to support the deprecation process and applies it tonix.settings, which has been causing a barrage of warnings for out-of-tree modules that still need to support the stable release, while backporting this change is not an option (and not really a sufficient solution anyway).Fixes #157667
Works around cachix/cachix#402 and similar issues elsewhere.
Companion PR extending the EOL process: NixOS/release-wiki#32
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes